Conversation
henrygd
left a comment
There was a problem hiding this comment.
Thank you, I appreciate your work on this.
However, I'm not sure that sending across all labels and controlling an alias in the UI is the best way to solve this problem.
It adds a potentially huge amount of extra data to transfer and store (containers can have thousands of labels), and the UI option may confuse people who aren't already familiar with this issue.
I'm a bit swamped at the moment, but I'll spin this up when I have time and spend a bit more time thinking about the best way to handle this.
|
Just my two cents: wouldn’t it be easier to read a label like |
|
We were talking about adding a But the problem is that multiple containers could have the same value for a label, and the charts don't handle this properly because we rely on the container name being unique to link different records together. We would probably need to store the container ID and link them with that. But that's not ideal because 1) it adds more data and 2) more importantly, IDs change when containers are recreated, which would break the continuity in the charts. So I'm not sure what the best solution is. Maybe we could just do something in the UI where we detect if that system has a container starting with |
This would only work for Coolify. There are other platforms that could benefit from a similar solution, but that would require adding specific support for each of them. That’s why I suggested using a custom label instead. It allows users to decide whether they want to use it or not and covers more use cases in my opinion. The agent could simply replace the current name value with the one defined in the label. |
📃 Description
This pull request introduces container aliasing with support for both manual and automatic alias management.
closes #1385
🪵 Changelog
➕ Added
📷 Screenshots