Skip to content

feat: add dismiss alert function#1766

Open
sternma wants to merge 1 commit intohenrygd:mainfrom
sternma:feat-1483-dismiss-alerts
Open

feat: add dismiss alert function#1766
sternma wants to merge 1 commit intohenrygd:mainfrom
sternma:feat-1483-dismiss-alerts

Conversation

@sternma
Copy link
Copy Markdown
Contributor

@sternma sternma commented Feb 22, 2026

📃 Description

Closes #1483 based on the disposition in the comments of the issue.

Adds the ability to dismiss alerts.

Note that this does not include any "snooze" functionality; this is particularly visible when developing with alert time set to 1 minute, as if you dismiss at 57 seconds into the profiling period, the alert will return again 3 seconds later. A later solution could be to add a "snooze" period, either automatic or configured, or somehow reset the timer for the profiling period for that specific alert type.

🪵 Changelog

➕ Added

  • feat: add dismiss alert function

📷 Screenshots

image image image

@sternma sternma requested a review from henrygd as a code owner February 22, 2026 20:30
@henrygd
Copy link
Copy Markdown
Owner

henrygd commented Feb 23, 2026

Thanks for your work on this.

Like you said, the downside to this approach is the alert will likely reappear soon after, since the condition that created the alert is still active. It can also create misleading end times in the alert history table.

Considering alternatives, maybe we could add a dismissed column in the alerts collection, then set that to true if the alert is dismissed. Then add some logic to not display in UI / not send notification if dismissed is true?

Let me know what you think.

If you want to edit the collection, just toggle the switch in PocketBase at /_/#/settings and edit them in the PocketBase UI -- any changes should automatically create a migration file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature ]: Add the option to dismiss alerts when the host goes offline

2 participants