Open
Conversation
Owner
|
Thanks for your work on this. Like you said, the downside to this approach is the alert will likely reappear soon after, since the condition that created the alert is still active. It can also create misleading end times in the alert history table. Considering alternatives, maybe we could add a Let me know what you think. If you want to edit the collection, just toggle the switch in PocketBase at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📃 Description
Closes #1483 based on the disposition in the comments of the issue.
Adds the ability to dismiss alerts.
Note that this does not include any "snooze" functionality; this is particularly visible when developing with alert time set to 1 minute, as if you dismiss at 57 seconds into the profiling period, the alert will return again 3 seconds later. A later solution could be to add a "snooze" period, either automatic or configured, or somehow reset the timer for the profiling period for that specific alert type.
🪵 Changelog
➕ Added
📷 Screenshots