Conversation
… alert names and UI updates.
|
Is it possibile to set for every container the trigger of unhealthy instead to set for everyone? |
Agree. The ux is not great IMO. The original issue had a much nicer mock up: |
Sure @kaysond |
@albertorizzi @kaysond : Check this approach. If it's still not functional, then I can try some different approach.
|
|
Just my two cents on the UI;
|
Agreed. Keeping the sheet focused on 'All Containers' and shifting the specific alerts to the Container Table is a cleaner approach. I’ll rework the UI now and get back to you with a fresh, updated look. |
|
Any news? |
henrygd
left a comment
There was a problem hiding this comment.
Sorry for lack of guidance, this is a fairly complex feature and I don't have enough time to go super in-depth right now.
All current alerts are based on systems. Rather than modifying the current alerts collection, it may be easier to create a new container_alerts collection. Likewise, it would probably be cleaner to make a separate alerts_container.go rather than mixing this in with alerts_system.go.
The functionality should work more like alerts_status.go anyway, since container health is a boolean state (unhealthy or not unhealthy), like system status (down or not down), rather than a value we need to average out and compare to a threshold like in alerts_system.go.
I'm also not completely satisfied with what I did in alerts_status.go, so it's not necessary to copy that pattern exactly. I'm sure there's a better way to do it.
We have access to all the container data on the hub side in system.go, so we can pass the data through to the alert functions somewhere around here:
beszel/internal/hub/systems/system.go
Lines 192 to 198 in afc19eb
IMO it would be best to make it a general "Container Health" alert that sends notifications when any containers on the system switch to / from unhealthy. We can add a way to exclude certain containers later, it doesn't need to be included in this PR. I'd rather keep the scope of this one as narrow as possible.
|
@henrygd Soon, I'll share the architecture change and UI in detail. In my mind also same thing is going on about |
…I endpoints, and UI components.
@henrygd @albertorizzi Check this UI screenshots |
|
@Jdbarad I use Notifiche Webhook / Push with Telegram. Is this flow implemented? |
Yes, That flow also implemented |
|
Pls review this devs 🙏 |
|
@henrygd Can you please review this updated code. |
|
I quickly reviewed it, everything seems to check. 🚀 |
|
I should be able to get to it this week, or at least relatively soon. Don't worry about merge conflicts. |
|
@henrygd Let me know if any help is needed. |







Container Health Alerts & UI Overhaul [#716]
📃 Description
This PR introduces comprehensive support for container health alerts and significantly overhauls the Alerts UI. It adds backend logic to monitor container health status and a redesigned, searchable frontend interface for efficient alert management in environments with high container counts.
📖 Documentation
Add a link to the PR for documentation changes.
🪵 Changelog
➕ Added
alertscollectionnamefield totext, supporting dynamic container alert names.✏️ Changed
HealthandStatusfields in container stats for frontend and alert system access.🔧 Fixed
useEffectto ensure the list stays in sync when switching between systems.🗑️ Removed
📷 Screenshots