Add reconnect logic for handling update failures in DbusService#250
Merged
Add reconnect logic for handling update failures in DbusService#250
Conversation
…d manage status codes
…sts for reconnect behavior and status code handling
dsteinkopf
requested changes
May 19, 2025
…rove error handling and retry mechanisms
…rove update logic
- Introduced ErrorMode configuration to switch between "retrycount" and "timeout" modes. - Updated DbusService to handle error states based on the selected mode. - Enhanced unit tests to cover new timeout behavior and ensure correct status code handling.
…n normal operation and add unit tests for successful update scenarios
- Added error handling mode and related configuration options to config.example. - Refactored DbusService to initialize and load error handling properties from configuration. - Updated unit tests to verify correct reading of error handling configuration values.
dsteinkopf
requested changes
Jul 12, 2025
Collaborator
dsteinkopf
left a comment
dsteinkopf
left a comment
There was a problem hiding this comment.
Added some comments.
… and update several places accordingly to the code review
dsteinkopf
requested changes
Aug 28, 2025
Collaborator
dsteinkopf
left a comment
dsteinkopf
left a comment
There was a problem hiding this comment.
Everything is functional ok. But after working on it for so long, we should clean it completely.
Collaborator
Author
|
I found another name for the variable. Please take a look at this. |
Collaborator
I like that. Nice :-) |
dsteinkopf
approved these changes
Sep 12, 2025
Collaborator
dsteinkopf
left a comment
dsteinkopf
left a comment
There was a problem hiding this comment.
Everything of fine now in my eyes. Good work. Thank you.
dsteinkopf
added a commit
that referenced
this pull request
Sep 14, 2025
* Add reconnect logic for AhoyDTU/OpenDTU after failed update attempts * Add reconnect logic tests for DbusService to handle update failures * Refactor DbusService tests to reset meter data and clean up comments * Implement reconnect logic in DbusService to handle update failures and manage status codes * Refactor ReconnectLogicTest to improve setup and add comprehensive tests for reconnect behavior and status code handling * Enhance reconnect logic in DbusService and configuration files to improve error handling and retry mechanisms * Add configuration options for retry logic in README and config.example * Refactor status code handling in DbusService to use constants and improve update logic * Add error handling modes and update logic in DbusService and tests - Introduced ErrorMode configuration to switch between "retrycount" and "timeout" modes. - Updated DbusService to handle error states based on the selected mode. - Enhanced unit tests to cover new timeout behavior and ensure correct status code handling. * Refactor DbusService update logic to ensure _refresh_data is called in normal operation and add unit tests for successful update scenarios * Add error handling modes to README and config.example for improved error management * Enhance error handling configuration in DbusService and tests - Added error handling mode and related configuration options to config.example. - Refactored DbusService to initialize and load error handling properties from configuration. - Updated unit tests to verify correct reading of error handling configuration values. * Refactor error handling logic in DbusService to fix the retry condition * Refactor error handling configuration in DbusService to use constants and update several places accordingly to the code review * minor changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce reconnect logic to manage update failures for AhoyDTU/OpenDTU, including status code handling and comprehensive tests. Refactor existing tests for clarity and improved setup.
Resolves #249