pin rust toolchain version in rust-toolchain file#2513
Closed
the-mikedavis wants to merge 1 commit intohelix-editor:masterfrom
Closed
pin rust toolchain version in rust-toolchain file#2513the-mikedavis wants to merge 1 commit intohelix-editor:masterfrom
the-mikedavis wants to merge 1 commit intohelix-editor:masterfrom
Conversation
Member
|
There's already a |
Member
Author
|
I did initially try that but it looks like the rustup version included in the actions runner is too old and it doesn't know about the |
Member
Author
|
I'll try out setting up a fork of actions-rs/toolchain. Having both versions of the rust-toolchain file seems hacky |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a less verbose alternative to #2512 that uses the rustup rust-toolchain file to pin the version of rust so new releases can't cause CI failures. Ideally
actions-rs/toolchainshould be able to supportrust-toolchain.tomlwhich already exists in this repo but it looks like there are a few PRs that haven't been updated in a while for adding support there. We may want to fork that action underhelix-editorand merge it ourselves to make this less hacky.