fix(term): clamp menu scroll on render to survive terminal resize#15678
Closed
lmarkmann wants to merge 1 commit intohelix-editor:masterfrom
Closed
fix(term): clamp menu scroll on render to survive terminal resize#15678lmarkmann wants to merge 1 commit intohelix-editor:masterfrom
lmarkmann wants to merge 1 commit intohelix-editor:masterfrom
Conversation
On a terminal resize, 'render' can run with 'area.height' smaller than what 'adjust_scroll' last clamped against, so 'cursor - scroll' underflows usize and the surface index panics. Re-clamp scroll at the top of render against the area we're about to draw into, as pascalkuthe suggested in #7089. Closes #6382
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6382.
On a terminal resize, 'render' can run with 'area.height' smaller than
what 'adjust_scroll' last clamped against, so 'cursor - scroll'
underflows usize and 'surface[(.., area.y + offset_from_top)]' panics.
Re-clamping at the top of render closes the race regardless of which
of 'render' or 'recalculate_size' fires first. Same approach
pascalkuthe suggested in
#7089 (comment).
Repro on master: open completion in a tall terminal, scroll past the
new height, shrink the window. Crashes. With this patch the menu
redraws clamped and the cursor stays visible.