transport: add itemName fallback for transport.ListPages()#12128
Merged
modular-magician merged 1 commit intohashicorp:mainfrom May 4, 2026
Conversation
…371) [upstream:b341eab546b69c25c699b3890a1e3f88d893bfc3] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
requested review from
a team,
NickElliot,
ScottSuarez,
SirGitsalot,
c2thorn,
hao-nan-li,
melinath,
rileykarson,
roaks3,
shuyama1,
slevenick,
trodge and
zli82016
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Note Template for Downstream PRs (will be copied)
I noticed that sweeper_file.go.tmpl includes a fallback for
itemswhen the default list key value is used but returns!okIncluding this fallback makes sense in the case of
ListPagesas we would default to usingcollection_url_keyin generated list resources but due to the generation not including the fallback an explicit change tocollection_url_key -> itemswas often necessarySee Write release notes for guidance.
Derived from GoogleCloudPlatform/magic-modules#17371