Use Document as Input in the SVGImageReader #452
Open
j-p-sequeira wants to merge 3 commits intoharaldk:masterfrom
Open
Use Document as Input in the SVGImageReader #452j-p-sequeira wants to merge 3 commits intoharaldk:masterfrom
j-p-sequeira wants to merge 3 commits intoharaldk:masterfrom
Conversation
Extend input support of the SVGImageReader to also allow Document objects to be used as well as ImageInputStream objects.
Extend input support of the SVGImageReader to also allow Document objects to be used as well as ImageInputStream objects.
Extend input support of the SVGImageReader to also allow Document objects to be used as well as ImageInputStream objects.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, here it is. What we discussed here:
#451
I included the method to also allow using a simple org.w3c.dom.Document. You can remove it if you don't like ; )
As a note, the base URI will be set if the passed documents have it properly set. However, if also using default reading parameters, like
reader.read(0, reader.getDefaultReadParam());the URI that will be used is always the one set in the parameters, which will be null by default (ignoring the valid one in the document).Hope this helps.
(I'm not used to GitHub, I hope I'm not doing anything wrong)