demos/sdlimage: set palette as source lut#122
Open
lukaslihotzki wants to merge 1 commit intohaasn:masterfrom
Open
demos/sdlimage: set palette as source lut#122lukaslihotzki wants to merge 1 commit intohaasn:masterfrom
lukaslihotzki wants to merge 1 commit intohaasn:masterfrom
Conversation
Owner
Owner
|
I'm not sure I'm happy with this way of handling it. Besides debanding, a lot of other things are already distorting palettes, e.g. custom shaders, interpolation, color range expansion... Proper palette format support needs to be implemented in libplacebo directly, as an initial input step before anything else. (It's also semantically unlike the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 3D LUT can be used to describe the palette for indexed formats. This is not ideal, but probably more helpful for users who want to display indexed formats than converting to ABGR8888 on the CPU.
Remaining issues: