Skip to content

adding ResourceShares support#1092

Open
ehmanel wants to merge 3 commits intogruntwork-io:masterfrom
mercedes-benz:add-resource-share
Open

adding ResourceShares support#1092
ehmanel wants to merge 3 commits intogruntwork-io:masterfrom
mercedes-benz:add-resource-share

Conversation

@ehmanel
Copy link
Copy Markdown

@ehmanel ehmanel commented Mar 27, 2026

Description

This PR adds support for ResourceShares, requested in #1108

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes

added support for ResourceShares

Elias Ehmann elias.ehmann@mercedes-benz.com, Mercedes-Benz AG on behalf of Mercedes-Benz Tech Innovation GmbH, Provider Information

@ehmanel ehmanel requested a review from denis256 as a code owner March 27, 2026 10:21
@ehmanel ehmanel force-pushed the add-resource-share branch from 4d74f1c to 3ff4db5 Compare March 27, 2026 12:19
@james00012
Copy link
Copy Markdown
Contributor

Hi @ehmanel, is this PR ready for review. I see [WIP] in title. Please ping me once it's ready for review.

@ehmanel ehmanel changed the title [WIP] adding ResourceShares support adding ResourceShares support Mar 31, 2026
@ehmanel
Copy link
Copy Markdown
Author

ehmanel commented Mar 31, 2026

@james00012

@james00012
Copy link
Copy Markdown
Contributor

Hi @ehmanel, friendly ping.

@james00012
Copy link
Copy Markdown
Contributor

Hi @ehmanel, can you also handle the branch conflicts? Thanks

@james00012
Copy link
Copy Markdown
Contributor

Thanks for addressing the prior feedback! The go.mod fix and status filter look good. However, the test data needs to be updated to include Status:types.ResourceShareStatusActive on shares that should pass the filter — currently all tests will fail because every share gets skipped by the new status check. Could you also add a test share with a non-active status (e.g., DELETED) to verify the filter works in both directions?

@ehmanel ehmanel force-pushed the add-resource-share branch from 1c83cdf to 6cf2115 Compare April 9, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants