Open
Conversation
4d74f1c to
3ff4db5
Compare
Contributor
|
Hi @ehmanel, is this PR ready for review. I see [WIP] in title. Please ping me once it's ready for review. |
Author
james00012
reviewed
Apr 1, 2026
Contributor
|
Hi @ehmanel, friendly ping. |
Contributor
|
Hi @ehmanel, can you also handle the branch conflicts? Thanks |
Contributor
|
Thanks for addressing the prior feedback! The go.mod fix and status filter look good. However, the test data needs to be updated to include Status:types.ResourceShareStatusActive on shares that should pass the filter — currently all tests will fail because every share gets skipped by the new status check. Could you also add a test share with a non-active status (e.g., DELETED) to verify the filter works in both directions? |
1c83cdf to
6cf2115
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for ResourceShares, requested in #1108
TODOs
Read the Gruntwork contribution guidelines.
nuke_sandboxandnuke_phxdevopsjobs in.circleci/config.ymlhave been updated with appropriate exclusions (either directly in the job or via the.circleci/nuke_config.ymlfile) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.Release Notes
added support for ResourceShares
Elias Ehmann elias.ehmann@mercedes-benz.com, Mercedes-Benz AG on behalf of Mercedes-Benz Tech Innovation GmbH, Provider Information