Fix flaky DuplexStream_SendToUnimplementedMethod_ThrowError test#2720
Merged
JamesNK merged 1 commit intogrpc:masterfrom Apr 23, 2026
Merged
Conversation
Drain the response stream before calling GetStatus() to ensure the call is fully complete. Previously, there was a race condition where ResponseHeadersAsync could complete before CallTask finished, causing GetStatus() to throw InvalidOperationException.
JamesNK
requested review from
BrennanConroy,
ReubenBond,
adityamandaleeka and
asheshvidyut
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix race condition in
DuplexStream_SendToUnimplementedMethod_ThrowErrorwhereGetStatus()throwsInvalidOperationExceptionbecauseCallTaskhasn't completed yet.\n\nThe test was awaitingResponseHeadersAsyncbefore callingGetStatus(), but receiving response headers doesn't guarantee the internal call is fully complete. The fix drains the response stream (viaMoveNextwhich throwsRpcException) before checking status, ensuring the call is fully finished.