Add an interceptor to support AuthenticationManagerResolver by mehrabisajad · Pull Request #1034 · grpc-ecosystem/grpc-spring

mehrabisajad · 2024-01-22T17:22:22Z

This proposal introduces the AuthenticationManagerResolver<GrpcServerRequest> to Spring's gRPC authentication framework. This provides a flexible mechanism for implementing dynamic authentication based on your specific needs.

The Problem:

Traditional Spring gRPC authentication relies on fixed configuration of authentication providers, limiting flexibility.
Changing authentication mechanisms requires code modifications and redeployments.

The Solution:

Introduce AuthenticationManagerResolver:
- Allows dynamic selection of the AuthenticationManager based on the gRPC request.
- Enables fine-grained control over authentication based on request headers, payload, or other criteria.

docs/en/server/security.md

...nfigure/src/main/java/net/devh/boot/grpc/server/security/interceptors/GrpcServerRequest.java

...h/boot/grpc/server/security/interceptors/ManagerResolverAuthenticatingServerInterceptor.java

ST-DDT · 2024-01-22T18:26:26Z

Nice suggestion, I'm currently quite busy so I might be slow to respond.

…it on subclasses

ST-DDT

Please add a test that checks whether this works as expected.

...net/devh/boot/grpc/server/security/interceptors/AbstractAuthenticatingServerInterceptor.java

docs/en/server/security.md

.../net/devh/boot/grpc/server/security/interceptors/DefaultAuthenticatingServerInterceptor.java

...nfigure/src/main/java/net/devh/boot/grpc/server/security/interceptors/GrpcServerRequest.java

...h/boot/grpc/server/security/interceptors/ManagerResolverAuthenticatingServerInterceptor.java

…tor related codes

...h/boot/grpc/server/autoconfigure/GrpcServerSecurityWithManagerResolverAutoConfiguration.java

...net/devh/boot/grpc/server/security/interceptors/AbstractAuthenticatingServerInterceptor.java

...h/boot/grpc/server/autoconfigure/GrpcServerSecurityWithManagerResolverAutoConfiguration.java

...nfigure/src/main/java/net/devh/boot/grpc/server/security/interceptors/GrpcServerRequest.java

...ava/net/devh/boot/grpc/test/config/WithBasicAuthAndManagerResolverSecurityConfiguration.java

ST-DDT · 2024-02-11T11:56:25Z

We moved some files. Could you please fix the merge conflicts?

# Conflicts: # grpc-server-spring-boot-starter/src/main/java/net/devh/boot/grpc/server/security/interceptors/AbstractAuthenticatingServerInterceptor.java # grpc-server-spring-boot-starter/src/main/java/net/devh/boot/grpc/server/security/interceptors/GrpcServerRequest.java # grpc-server-spring-boot-starter/src/main/java/net/devh/boot/grpc/server/security/interceptors/ManagerResolverAuthenticatingServerInterceptor.java

mehrabisajad · 2024-04-01T12:59:07Z

Great, I've fixed the merge conflicts that arose due to the file movements. I've carefully reviewed the changes and believe everything is now in sync.

I've pushed the changes to the branch. Could you please take a look at the latest version and let me know if you have any further questions or require additional modifications?

ST-DDT

Implementation wise looks good to me, but I have no time to check the security/config side effects.

...h/boot/grpc/server/security/interceptors/ManagerResolverAuthenticatingServerInterceptor.java

…pc/server/security/interceptors/ManagerResolverAuthenticatingServerInterceptor.java

...h/boot/grpc/server/security/interceptors/ManagerResolverAuthenticatingServerInterceptor.java

…pc/server/security/interceptors/ManagerResolverAuthenticatingServerInterceptor.java

ST-DDT

I haven't tested this myself and I'm unsure about the change in condition regarding when the security config is enabled.

Other than that, it looks good to me.

...h/boot/grpc/server/security/interceptors/ManagerResolverAuthenticatingServerInterceptor.java

.../net/devh/boot/grpc/server/security/interceptors/DefaultAuthenticatingServerInterceptor.java

mehrabisajad · 2024-04-15T11:27:12Z

I haven't tested this myself and I'm unsure about the change in condition regarding when the security config is enabled.

Other than that, it looks good to me.

If on of the interceptors condition met, then it will be registered. On the other hand if both conditions met then the first one will be registered according to the priority.

According to existing GrpcServerSecurityAutoConfiguration Conditions, if GrpcAuthenticationReader is not registered, I think it will probably encounter error. So all the configuration depends on GrpcAuthenticationReader.

If you have any other situation to consider, please let me know.

...h/boot/grpc/server/security/interceptors/ManagerResolverAuthenticatingServerInterceptor.java

Add an interceptor to support AuthenticationManagerResolver

13295e3

ST-DDT reviewed Jan 22, 2024

View reviewed changes

Create an abstract class for AuthenticatingServerInterceptor and use …

4f73dcc

…it on subclasses

ST-DDT reviewed Jan 25, 2024

View reviewed changes

mehrabisajad and others added 3 commits January 28, 2024 15:52

Add test for ManagerResolverAuthenticatingServerInterceptor and refac…

802ad1f

…tor related codes

Refactor using spotlessApply and Add new autoconfiguration

9a39d9b

Merge branch 'master' into support-AuthenticationManagerResolver

276ec90

ST-DDT reviewed Feb 3, 2024

View reviewed changes

Merge AutoConfig and Edit AuthenticationManagerResolver behavior

23f5fa1

mehrabisajad added 2 commits February 17, 2024 12:14

Merge branch 'master' into support-AuthenticationManagerResolver

a5904ab

ST-DDT previously approved these changes Apr 1, 2024

View reviewed changes

...h/boot/grpc/server/security/interceptors/ManagerResolverAuthenticatingServerInterceptor.java Outdated Show resolved Hide resolved

ST-DDT added 2 commits April 13, 2024 09:13

Merge branch 'master' into support-AuthenticationManagerResolver

5c718a0

Update grpc-server-spring-boot-starter/src/main/java/net/devh/boot/gr…

9305837

…pc/server/security/interceptors/ManagerResolverAuthenticatingServerInterceptor.java

ST-DDT dismissed their stale review via 9305837 April 13, 2024 07:14

ST-DDT reviewed Apr 13, 2024

View reviewed changes

...h/boot/grpc/server/security/interceptors/ManagerResolverAuthenticatingServerInterceptor.java Show resolved Hide resolved

Update grpc-server-spring-boot-starter/src/main/java/net/devh/boot/gr…

4a754c2

…pc/server/security/interceptors/ManagerResolverAuthenticatingServerInterceptor.java

ST-DDT previously approved these changes Apr 13, 2024

View reviewed changes

...h/boot/grpc/server/security/interceptors/ManagerResolverAuthenticatingServerInterceptor.java Outdated Show resolved Hide resolved

.../net/devh/boot/grpc/server/security/interceptors/DefaultAuthenticatingServerInterceptor.java Outdated Show resolved Hide resolved

Remove unnecessary Autowired annotation

58b356e

mehrabisajad dismissed ST-DDT’s stale review via 58b356e April 15, 2024 11:40

Merge branch 'master' into support-AuthenticationManagerResolver

5bbb550

ST-DDT reviewed Apr 15, 2024

View reviewed changes

...h/boot/grpc/server/security/interceptors/ManagerResolverAuthenticatingServerInterceptor.java Outdated Show resolved Hide resolved

Remove unused import statement

0c863e8

ST-DDT approved these changes Apr 15, 2024

View reviewed changes

Conversation

mehrabisajad commented Jan 22, 2024

The Problem:

The Solution:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ST-DDT commented Jan 22, 2024

Uh oh!

ST-DDT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ST-DDT commented Feb 11, 2024

Uh oh!

mehrabisajad commented Apr 1, 2024

Uh oh!

ST-DDT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ST-DDT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mehrabisajad commented Apr 15, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants