Skip to content

Fix(4008): Set client id if empty on update extclient.#4009

Open
VishalDalwadi wants to merge 2 commits into
developfrom
fix-4008
Open

Fix(4008): Set client id if empty on update extclient.#4009
VishalDalwadi wants to merge 2 commits into
developfrom
fix-4008

Conversation

@VishalDalwadi
Copy link
Copy Markdown
Collaborator

Describe your changes

Fixes: #4008

Set client id if empty on update extclient.

Provide Issue ticket number if applicable/not in title

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

@VishalDalwadi VishalDalwadi changed the title Fix: 4008 Fix(4008): Set client id if empty on update extclient. May 12, 2026
@tenki-reviewer
Copy link
Copy Markdown
Contributor

tenki-reviewer Bot commented May 12, 2026

Tenki Code Review - Complete

Risk: 🟢 Low (3/100) — no findings · 3 LOC across 1 file

Files Reviewed: 1
Findings: 0


A minimal, correct defensive guard is added to updateExtClient that prevents a client from accidentally clearing its own ClientID when the update payload omits that field. No bugs or security issues are introduced.

Files Reviewed (1 files)
controllers/ext_client.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants