Save event_no as a non-index column in ParquetWriter#872
Open
astrojarred wants to merge 1 commit intographnet-team:mainfrom
Open
Save event_no as a non-index column in ParquetWriter#872astrojarred wants to merge 1 commit intographnet-team:mainfrom
astrojarred wants to merge 1 commit intographnet-team:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main change here is that instead of setting the
self._index_columnto the index, we just let it stay as a normal column in the dataframe/parquet file.This way later we don't get 'column not found' errors when merging files in these places:
_process_shard()when callingid = split[index_column]_identify_events()when doingdf.select([index_column])This fixes the bug I was having but would need a maintainer/expert to let me know if this might mess things up downstream, i.e. if somewhere else
event_nois expected as an index column. In this case we could just set the index again at the very end of the merging process.Fixes #871