add RegisterServiceEntry function#107
Open
oliverpool wants to merge 2 commits intograndcat:masterfrom
Open
Conversation
ec6914c to
f7c74fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #52 (which seems stale), this adds a
RegisterServiceEntryfunction.To be able to override specific fields of the
ServiceEntry(theHostNamefor instance, without having to provideips).I refactored the
RegisterandRegisterProxyto use this new method.I have added some basic tests, to check that the fields are properly set.
Let me know what you think!