feat(classfile): annotate spx resource schema#1491
Draft
aofei wants to merge 1 commit intogoplus:devfrom
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces xgo metadata annotations across several files to define resource classes, discovery patterns, and API scope bindings for types such as Monitor, Sprite, and various name aliases. These tags are used to facilitate resource management and discovery within the xgo framework. A review comment points out a potential typo in the discovery pattern for SpriteAnimationName, suggesting it be updated to maintain consistency with the naming conventions used for other resources in the project.
Add classfile resource directives to the exported resource name types and handle-bearing widget and sprite types in spx. Also annotate the public `Sprite` API surface and the corresponding `SpriteImpl` methods with `resource-api-scope-binding` directives for scoped costume and animation resources. Updates goplus/xgo#2704 Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
aofei
force-pushed
the
classfile-resource-directive-comments
branch
from
1ad9a44 to
00ad362
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add classfile resource directives to the exported resource name types and handle-bearing widget and sprite types in spx.
Also annotate the public
SpriteAPI surface and the correspondingSpriteImplmethods withresource-api-scope-bindingdirectives for scoped costume and animation resources.Updates goplus/xgo#2704