Skip to content

docs: refine Copilot generalization design#3047

Draft
nighca wants to merge 1 commit intogoplus:devfrom
nighca:issue-2808
Draft

docs: refine Copilot generalization design#3047
nighca wants to merge 1 commit intogoplus:devfrom
nighca:issue-2808

Conversation

@nighca
Copy link
Copy Markdown
Collaborator

@nighca nighca commented Apr 20, 2026

Refs #2808

Summary

Notes

  • documentation-only change
  • no tests were run

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request outlines the technical design for generalizing XBuilder's Copilot, moving from a project-specific implementation to a modular, skill-based architecture. Key changes include decoupling platform-level logic from project-specific context, introducing an in-memory skill registry, and implementing a progressive disclosure model via a new load_skill tool. Review feedback identifies inconsistencies in the proposed TypeScript interfaces and contradictions between the tool implementation snippets and the specified output format.

name: string
path: string
content: string
resourcePaths: string[]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The LoadedSkillDocument type includes resourcePaths: string[]. However, the examples in Section 6 show that only the main skill document lists resources, while individual resource documents do not. To align with this, consider making resourcePaths optional so it can be omitted for resource documents.

.describe('Optional relative path of a markdown resource within the skill bundle. Omit to load SKILL.md')
}),
async implementation({ skillId, resourcePath }) {
return skillRegistry.load(skillId, resourcePath ?? null)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This code snippet shows the tool returning a LoadedSkillDocument object directly. This contradicts Section 6, which specifies that the tool should return a structured XML-like string (e.g., wrapped in <skill_content>). The implementation should be updated to include the formatting step to ensure consistency within the design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant