fix: correct node/package.json main field to existing index.mjs#1418
Open
cybermanhao wants to merge 1 commit intogoogleapis:mainfrom
Open
fix: correct node/package.json main field to existing index.mjs#1418cybermanhao wants to merge 1 commit intogoogleapis:mainfrom
cybermanhao wants to merge 1 commit intogoogleapis:mainfrom
Conversation
The main field pointed to ../dist/node/index.js which does not exist. Only index.mjs and index.cjs are present in dist/node/. This causes resolution failures in tools (e.g. tsx) that fall back to the subdirectory package.json main field instead of reading the parent package exports map.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
node/package.jsonhas:{ "main": "../dist/node/index.js" }But
dist/node/index.jsdoes not exist. The actual files present are:dist/node/index.mjsdist/node/index.cjsImpact
Most environments are unaffected because Node.js and modern bundlers (webpack, rollup, etc.) resolve
@google/genai/nodevia the parent packageexportsfield, which correctly maps toindex.mjs/index.cjs.However, tools that fall back to subdirectory
package.jsonmainfields — such astsx's custom ESM resolver — will encounter aCannot find moduleerror:Fix
Point
mainto the file that actually exists:{ "main": "../dist/node/index.mjs" }Notes
tsx'sresolveDirectorybypassing the parent packageexportsmap — that is a separate issue intsxmainfield consistent with reality, which is a defensive improvement regardless