Skip to content

[hermes] Unfold, use grind in automatic proofs#3215

Open
joshlf wants to merge 1 commit intomainfrom
G5iiniran72qxcjixnuxghrjo5paoe57n
Open

[hermes] Unfold, use grind in automatic proofs#3215
joshlf wants to merge 1 commit intomainfrom
G5iiniran72qxcjixnuxghrjo5paoe57n

Conversation

@joshlf
Copy link
Copy Markdown
Member

@joshlf joshlf commented Apr 7, 2026

In autoParam automatic proofs, insert unfold and grind tactics in
various places. unfold is crucial – without it, only statements
which are universally true for all possible implementations of the
function signature can be automatically proven. grind is an SMT-based
tactic which is able to automatically discharge a wide range of proofs.

Closes #3210
Closes #3213


Latest Update: v2 — Compare vs v1

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v1 Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/G5iiniran72qxcjixnuxghrjo5paoe57n && git checkout -b pr-G5iiniran72qxcjixnuxghrjo5paoe57n FETCH_HEAD

Checkout

git fetch origin refs/heads/G5iiniran72qxcjixnuxghrjo5paoe57n && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/G5iiniran72qxcjixnuxghrjo5paoe57n && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/G5iiniran72qxcjixnuxghrjo5paoe57n

Stacked PRs enabled by GHerrit.

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (9252871) to head (00bed26).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3215   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          20       20           
  Lines        6067     6067           
=======================================
  Hits         5573     5573           
  Misses        494      494           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

In `autoParam` automatic proofs, insert `unfold` and `grind` tactics in
various places. `unfold` is crucial – without it, *only* statements
which are universally true for all possible implementations of the
function signature can be automatically proven. `grind` is an SMT-based
tactic which is able to automatically discharge a wide range of proofs.

Closes #3210
Closes #3213

gherrit-pr-id: G5iiniran72qxcjixnuxghrjo5paoe57n
@joshlf joshlf force-pushed the G5iiniran72qxcjixnuxghrjo5paoe57n branch from 20aa2f7 to 00bed26 Compare April 7, 2026 05:13
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@joshlf joshlf enabled auto-merge April 7, 2026 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unfold function definition in auto-proofs Use grind tactic in auto-proofs

2 participants