Skip to content

[WIP][hermes] Parse attributes with chumsky#3154

Open
joshlf wants to merge 1 commit intomainfrom
Gczb3453nnkbkcyi7ljygagmk7mgyse2o
Open

[WIP][hermes] Parse attributes with chumsky#3154
joshlf wants to merge 1 commit intomainfrom
Gczb3453nnkbkcyi7ljygagmk7mgyse2o

Conversation

@joshlf
Copy link
Copy Markdown
Member

@joshlf joshlf commented Mar 27, 2026


Latest Update: v6 — Compare vs v5

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v5 v4 v3 v2 v1 Base
v6 vs v5 vs v4 vs v3 vs v2 vs v1 vs Base
v5 vs v4 vs v3 vs v2 vs v1 vs Base
v4 vs v3 vs v2 vs v1 vs Base
v3 vs v2 vs v1 vs Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gczb3453nnkbkcyi7ljygagmk7mgyse2o && git checkout -b pr-Gczb3453nnkbkcyi7ljygagmk7mgyse2o FETCH_HEAD

Checkout

git fetch origin refs/heads/Gczb3453nnkbkcyi7ljygagmk7mgyse2o && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gczb3453nnkbkcyi7ljygagmk7mgyse2o && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gczb3453nnkbkcyi7ljygagmk7mgyse2o

Stacked PRs enabled by GHerrit.

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@joshlf joshlf force-pushed the Gczb3453nnkbkcyi7ljygagmk7mgyse2o branch from ea64671 to a51a0b4 Compare March 27, 2026 20:04
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (61b2407) to head (dc085f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3154   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          20       20           
  Lines        6067     6067           
=======================================
  Hits         5573     5573           
  Misses        494      494           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf joshlf force-pushed the Gczb3453nnkbkcyi7ljygagmk7mgyse2o branch from a51a0b4 to 7948c18 Compare March 27, 2026 20:45
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@joshlf joshlf force-pushed the Gczb3453nnkbkcyi7ljygagmk7mgyse2o branch from 7948c18 to 7b1f60b Compare March 27, 2026 22:30
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@joshlf joshlf force-pushed the Gczb3453nnkbkcyi7ljygagmk7mgyse2o branch from 7b1f60b to b4808ba Compare March 27, 2026 23:23
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

gherrit-pr-id: Gczb3453nnkbkcyi7ljygagmk7mgyse2o
@joshlf joshlf force-pushed the Gczb3453nnkbkcyi7ljygagmk7mgyse2o branch from b4808ba to dc085f4 Compare March 28, 2026 00:36
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants