pkg/aflow: provide better kernel build errors#7007
pkg/aflow: provide better kernel build errors#7007a-nogikh wants to merge 2 commits intogoogle:masterfrom
Conversation
When reporting a kernel build error, also try to include the build error report. Otherwise it's hard to understand what happened.
|
Update #6896 |
| if buildErr == err { | ||
| return aflow.FlowError(err) | ||
| } | ||
| return aflow.FlowError(fmt.Errorf("%w\n\nRoot cause:\n%w", err, buildErr)) |
There was a problem hiding this comment.
I think this won't work. The problem is that we truncate errors, see #6896.
At the very least we should print buildErr first, and maybe take the last part of err.
There was a problem hiding this comment.
But the current err should actually be quite small, right?
It doesn't include the full output:
syzkaller/pkg/osutil/osutil.go
Lines 120 to 122 in 50cdcaa
ExtractRootCause's output should also be reasonably small:
Lines 136 to 138 in 50cdcaa
I think it should fit even without truncation.
There was a problem hiding this comment.
We may prepend the full output later b/c what you on the dashboard is not the short output, it's full output.
There was a problem hiding this comment.
In the context of #6896, we'd probably want to keep what we keep in Error reasonably short (= do not keep full logs there) for display in the trajectory table and separately store the full log separately (and make it available via some link).
|
Just in case. |
|
@a-nogikh I started something but I paused it for something else. You can keep going with this. |
When reporting a kernel build error, also try to include the build error report. Otherwise it's hard to understand what happened, see e.g. https://syzkaller.appspot.com/ai_job?id=55a13c60-a5f5-4f2c-8ea9-d5e1b343572c