Skip to content

pkg/aflow: add the Format action for repro.go#6919

Merged
ramosian-glider merged 2 commits intogoogle:masterfrom
ramosian-glider:syz-aflow-110326
Mar 12, 2026
Merged

pkg/aflow: add the Format action for repro.go#6919
ramosian-glider merged 2 commits intogoogle:masterfrom
ramosian-glider:syz-aflow-110326

Conversation

@ramosian-glider
Copy link
Copy Markdown
Member


Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md


@ramosian-glider
Copy link
Copy Markdown
Member Author

@dvyukov there's a concurrent suggestion by @tarasmadan to rename the parameters globally before running the actions.

@ramosian-glider ramosian-glider force-pushed the syz-aflow-110326 branch 2 times, most recently from b05f268 to fd007ff Compare March 12, 2026 10:57
@ramosian-glider
Copy link
Copy Markdown
Member Author

PTAL

I also have the following diff to GEMINI.md, I can include it here:


diff --git a/pkg/aflow/GEMINI.md b/pkg/aflow/GEMINI.md
index 73808137c..df4fde530 100644
--- a/pkg/aflow/GEMINI.md
+++ b/pkg/aflow/GEMINI.md
@@ -36,6 +36,21 @@ typically through the `syz-env` wrapper.
 
 ## Development Conventions
 
+### State Variable Naming Conventions
+
+To allow actions and workflows to be composed without complex renaming logic, we attach **semantic meaning** to state variable names rather than just using raw types.
+
+We globally agree on the semantics of names so that actions can work securely across any context:
+
+- **`BugTitle`**: The original bug title straight from the dashboard.
+- **`ReproducedBugTitle`**: The bug title that resulted from successfully running a reproducer.
+- **`CrashReport`**: The verbatim bug report body to reproduce.
+- **`CandidateReproSyz`**: A raw, unformatted syzkaller program typically generated directly by the LLM.
+- **`ReproSyz`**: A definitively formatted, verified, and ready-to-execute syzkaller program (e.g. the output of the `Format` action).
+- **`ReproOpts`**: Reproducer configuration options.
+- **`KernelRepo` / `KernelBranch` / `KernelCommit`**: Information uniquely identifying the target kernel tree and revision.
+- **`KernelConfig`**: The kernel build setup configuration.
+
 ### Defining Workflows
 
 Workflows are typically registered using `aflow.Register`.

@dvyukov
Copy link
Copy Markdown
Collaborator

dvyukov commented Mar 12, 2026

I also have the following diff to GEMINI.md, I can include it here:

whichever you prefer

dvyukov
dvyukov previously approved these changes Mar 12, 2026
The new action deserializes and serializes the program to ensure
it is formatted properly.
Start collecting some state variable naming conventions in GEMINI.md,
so that it's easier to write new actions and tools.
@ramosian-glider ramosian-glider added this pull request to the merge queue Mar 12, 2026
Merged via the queue into google:master with commit f48b4d1 Mar 12, 2026
18 checks passed
@ramosian-glider ramosian-glider changed the title pkg/aflow: add the Normalize action for repro.go pkg/aflow: add the Format action for repro.go Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants