Use dynamic previous month length for monthly email reports#12397
Open
officialasishkumar wants to merge 1 commit intogoogle:developfrom
Open
Use dynamic previous month length for monthly email reports#12397officialasishkumar wants to merge 1 commit intogoogle:developfrom
officialasishkumar wants to merge 1 commit intogoogle:developfrom
Conversation
Replace the hardcoded 30-day period with the actual number of days
in the month of the send date using DateTimeImmutable::format('t').
This ensures monthly reports always cover the correct calendar
month regardless of its length (28, 29, 30, or 31 days).
Update the frontend label from "Last 28 days" to "Last month" and
add parameterised test cases covering all month-length variants
including leap year February.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PHP (
Initiator_Task::build_reference_dates): Replaced the hardcoded30forFREQUENCY_MONTHLYwith(int) $send_date->format( 't' ), which returns the number of days in the month that$send_datefalls in. Since the monthly initiator fires on the 1st and$send_dateis computed asscheduled_date - 1 day,$send_dateis always the last day of the previous month, soformat('t')yields the correct count (28, 29, 30, or 31).JS (
FrequencySelector): Updated the monthly period label from "Last 28 days" to "Last month" to reflect the dynamic nature of the reporting window.Tests (
Initiator_TaskTest): Expanded thedata_build_reference_dates_uses_expected_period_lengthdata provider to include parameterised test cases for all month-length variants:The test method signature was updated to accept a timestamp string, allowing each case to use the appropriate boundary date. Snapshot files are updated accordingly.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist