Conversation
|
It would be nice to keep this in the embedder implementation instead of having to modify the default list. But maybe there's a way to do this already that I missed? |
🎨 Perfetto UI Builds
|
|
Wouldn't it be far better to just move the default plugin list to the embedder interface? That seems like a no-brainer instead of adding a lambda for this. |
I would like to avoid having the embedder be aware of all default plugins. Eg. the change we made to move some gpu related code from TPTrack plugin to a new Gpu plugin shouldn't require all downstream embedders to update their code. But maybe you're suggesting moving into the embedder in a way that would allow this? |
|
I mean ultimately in my mind how the embedder chooses to modify the embedded list is an implementation detail. You are free to depend on the upstream embedded definition and modify it or wholesale replace it. I just don't think the API should be a lambda, that just feel weird to me. |
29d2a06 to
04ffb68
Compare
Ah, done. Ptal. |
04ffb68 to
4e3c53c
Compare
LalitMaganti
left a comment
There was a problem hiding this comment.
Looks good to me but will leave to Steve to confirm he's happy.
Allow embedders to control which plugins are enabled by default by adding a required defaultPlugins property to the Embedder interface. Both existing embedders return the built-in default list, preserving current behavior while letting third-party embedders customize it. Move default_plugins.ts into the embedder folder and pass the default plugin list to PluginManagerImpl via the constructor.
4e3c53c to
d9c9e80
Compare
@stevegolton Let me know how this looks to you. |
Allow embedders to control which plugins are enabled by default by
adding a required defaultPlugins property to the Embedder interface.
Both existing embedders return the built-in default list, preserving
current behavior while letting third-party embedders customize it.
Move default_plugins.ts into the embedder folder and pass the
default plugin list to PluginManagerImpl via the constructor.