Create unique IDs for jank and latency CUJs#5345
Merged
Conversation
android_jank_latency_cujs table within sysui_cujs.sql within Perfetto stdlib is a union of two tables: android_sysui_jank_cujs and android_sysui_latency_cujs. Each table has its own set of cuj_ids which are only unique within each table, but not across all CUJs. This creates a problem downstream, as we end up with multiple CUJs with the same id but of different names. So fix this by generating new unique ids across the union. Bug: 496902302 Test: tools/diff_test_trace_processor.py \ out/android/trace_processor_shell
🎨 Perfetto UI Builds
|
nicomazz
approved these changes
Mar 30, 2026
LalitMaganti
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
android_jank_latency_cujs table within sysui_cujs.sql
within Perfetto stdlib is a union of two tables:
android_sysui_jank_cujs and android_sysui_latency_cujs.
Each table has its own set of cuj_ids which are only unique within each table,
but not across all CUJs.
This creates a problem downstream, as we end up with multiple CUJs
with the same id but of different names.
So fix this by generating new unique ids across the union.
Bug: 496902302
Test: tools/diff_test_trace_processor.py
out/android/trace_processor_shell