tp: introduce TreeColumns and refactor TreeTransformer to use it#5262
Merged
LalitMaganti merged 28 commits intomainfrom Mar 30, 2026
Merged
tp: introduce TreeColumns and refactor TreeTransformer to use it#5262LalitMaganti merged 28 commits intomainfrom
LalitMaganti merged 28 commits intomainfrom
Conversation
🎨 Perfetto UI Builds
|
Add TreeColumns, a simple columnar storage type for tree data with a normalized parent array and dense null bitvectors. Add TreeColumnsBuilder which wraps RuntimeDataframeBuilder for type inference and null tracking, then converts the result to TreeColumns via a new BuildRaw() short-circuit on AdhocDataframeBuilder that returns raw FlexVectors + BitVectors without sort analysis, type downcasting, or Dataframe creation. TreeTransformer now takes TreeColumns instead of Dataframe, and TreeFromTable builds TreeColumns directly. This eliminates the need to destructure a Dataframe in the TreeTransformer constructor and provides a cleaner, tree-specific data representation.
LalitMaganti
force-pushed
the
dev/lalitm/tree-columns-refactor
branch
from
9dd318b to
1566928
Compare
Member
Author
|
Done PTAL. |
sashwinbalaji
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TreeColumns, a simple columnar storage type for tree data with normalized parent array and dense null bitvectorsTreeColumnsBuilderwhich wrapsRuntimeDataframeBuilderfor type inference/null tracking, then converts via a newBuildRaw()short-circuit that skips sort analysis, type downcasting, and Dataframe creationTreeTransformernow takesTreeColumnsinstead ofDataframeStack
Test plan