tp: fix descendant_slice missing boundary instant children#5239
Merged
LalitMaganti merged 23 commits intomainfrom Mar 30, 2026
Merged
tp: fix descendant_slice missing boundary instant children#5239LalitMaganti merged 23 commits intomainfrom
LalitMaganti merged 23 commits intomainfrom
Conversation
descendant_slice used strict Lt for the upper timestamp bound, which excluded instant children at exactly ts + dur. These children have a valid parent_id link (set during ingestion while the parent was still open) but were missed by the geometric filter. Switch to Le and verify candidates at the end boundary with a parent chain walk, matching the existing start-boundary logic. Add a regression test reproducing the real-world sequence: Begin(parent) -> Scoped(instant@boundary) -> End(parent).
🎨 Perfetto UI Builds
|
aMayzner
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
descendant_slice used strict Lt for the upper timestamp bound,
which excluded instant children at exactly ts + dur. These
children have a valid parent_id link (set during ingestion while
the parent was still open) but were missed by the geometric
filter.
Switch to Le and verify candidates at the end boundary with a
parent chain walk, matching the existing start-boundary logic.
Add a regression test reproducing the real-world sequence:
Begin(parent) -> Scoped(instant@boundary) -> End(parent).