[opencv] Fix core_fuzzer: catch exception by reference instead of by value#15263
Open
OwenSanzas wants to merge 1 commit intogoogle:masterfrom
Open
[opencv] Fix core_fuzzer: catch exception by reference instead of by value#15263OwenSanzas wants to merge 1 commit intogoogle:masterfrom
OwenSanzas wants to merge 1 commit intogoogle:masterfrom
Conversation
|
OwenSanzas has previously contributed to projects/opencv. The previous PR was #15092 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All
catchblocks usecatch (cv::Exception e)(catch by value) instead ofcatch (cv::Exception& e)(catch by reference). Catching by value copies the exception object, which is unnecessary and can slice derived exception types.Fix: Change all
catch (cv::Exception e)tocatch (cv::Exception& e).Coverage comparison (60 seconds, empty seed corpus, ASan, libFuzzer)
Note: The coverage improvement may be due to fuzzer randomness, but confirms the fix does not regress coverage.