Use nulls instead of sentinels.#7886
Merged
copybara-service[bot] merged 1 commit intomasterfrom Jul 25, 2025
Merged
Conversation
copybara-service
bot
force-pushed
the
test_784673096
branch
2 times, most recently
from
da43c58 to
5b8182b
Compare
Motivation: - (the real motivation) Eliminate reference cycles. Reference cycles can cause trouble for J2ObjC. Our cycle tests don't actually detect any problems here, but my understanding is that they aren't intended to catch _everything_. - Avoid "cheating" in how we annotate for nullness. (On the topic of nullness: It's of course reasonable to worry about how this CL uses `null` more. But we've had nullness checking in place for years here, and I saw good results from IntelliJ and our build-time checking.) - Overall, simplify the code. - Save the tiniest bit of memory :) RELNOTES=n/a PiperOrigin-RevId: 787098790
copybara-service
bot
force-pushed
the
test_784673096
branch
from
5b8182b to
b085270
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use nulls instead of sentinels.
Motivation:
nullmore. But we've had nullness checking in place for years here, and I saw good results from IntelliJ and our build-time checking.)RELNOTES=n/a