Open
Conversation
Taken from the upstream repo https://github.com/strichpunkt-design/Strichpunkt_Sans at commit strichpunkt-design/Strichpunkt_Sans@9a24fe3.
10 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
FontSpector reportfontspector version: 1.6.0 Check results[1] ofl/strichpunktsans/METADATA.pbℹ️ INFO Check METADATA.pb parses correctly (googlefonts/metadata/validate)
[5] ofl/strichpunktsans🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field. (googlefonts/metadata/consistent_repo_urls)
🔥 FAIL Tofu should not be shown in sample texts. (googlefonts/tofu)
|
| Message | Languages |
|---|---|
| Auxiliary orthography codepoints: | * en_Latn (English) |
| The following auxiliary characters are missing from the font: ʻ | |
| Auxiliary orthography codepoints: | * fi_Latn (Finnish) |
| The following auxiliary characters are missing from the font: Ǧ | |
| The following auxiliary characters are missing from the font: Ǥ | |
| The following auxiliary characters are missing from the font: Ȟ | |
| The following auxiliary characters are missing from the font: Ǩ | |
| The following auxiliary characters are missing from the font: Ʒ | |
| The following auxiliary characters are missing from the font: Ǯ | |
| The following auxiliary characters are missing from the font: ǧ | |
| The following auxiliary characters are missing from the font: ǥ | |
| The following auxiliary characters are missing from the font: ȟ | |
| The following auxiliary characters are missing from the font: ǩ | |
| The following auxiliary characters are missing from the font: ʒ | |
| The following auxiliary characters are missing from the font: ǯ | |
| Auxiliary orthography codepoints: | * fr_Latn (French) |
| The following auxiliary characters are missing from the font: Ǔ | |
| The following auxiliary characters are missing from the font: ſ | |
| The following auxiliary characters are missing from the font: ǔ | |
| Auxiliary orthography codepoints: | * nl_Latn (Dutch) |
| The following auxiliary characters are missing from the font: IJ | |
| The following auxiliary characters are missing from the font: ij | |
| Auxiliary orthography codepoints: | * de_Latn (German) |
| The following auxiliary characters are missing from the font: ſ |
⚠️ WARN Are there any misaligned on-curve points? (outline_alignment_miss)
⚠️ WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
-
- aring (U+00E5): X=298,Y=702 (should be at cap-height 700?)
-
- aring (U+00E5): X=230,Y=702 (should be at cap-height 700?)
-
- b (U+0062): X=261.5,Y=2.5 (should be at baseline 0?)
-
- d (U+0064): X=331.5,Y=2.5 (should be at baseline 0?)
-
- dcaron (U+010F): X=331.5,Y=2.5 (should be at baseline 0?)
-
- dcroat (U+0111): X=331.5,Y=2.5 (should be at baseline 0?)
-
- uni0123 (U+0123): X=333,Y=702 (should be at cap-height 700?)
-
- uni0123 (U+0123): X=287,Y=702 (should be at cap-height 700?)
-
- p (U+0070): X=261.5,Y=2.5 (should be at baseline 0?)
... and 27 others [code: found-misalignments]
- p (U+0070): X=261.5,Y=2.5 (should be at baseline 0?)
ℹ️ INFO Checking OS/2 fsSelection value. (opentype/xavgcharwidth)
- ℹ️ INFO OS/2 xAvgCharWidth is 567 but it should be 566 which corresponds to the average of the widths of all glyphs in the font. These are similar values, which may be a symptom of the slightly different calculation of the xAvgCharWidth value in font editors. There's further discussion on this at com.google.fonts/test/034: xAvgCharWidth bakery vs glyphs vs font val fonttools/fontbakery#1622 [code: xAvgCharWidth-close]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| StrichpunktSans[wdth,wght].ttf | |
|---|---|
| Dehinted Size | 224656 |
| Hinted Size | 224680 |
| Increase | 24 |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
-
ℹ️ INFO "latin, latin-ext" [code: dlng-tag]
-
ℹ️ INFO "latin, latin-ext" [code: slng-tag]
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.000 [code: version-not-detected]
[1] ofl/strichpunktsans/article/ARTICLE.en_us.html
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
- ℹ️ INFO Found a git repo URL: https://github.com/strichpunkt-design/Strichpunkt_Sans [code: url-found]
Summary
| 🔥 FAIL | ℹ️ INFO | ✅ PASS | ⏩ SKIP | |
|---|---|---|---|---|
| 5 | 5 | 10 | 160 | 40 |
| 2% | 2% | 5% | 74% | 19% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken from the upstream repo https://github.com/strichpunkt-design/Strichpunkt_Sans at commit strichpunkt-design/Strichpunkt_Sans@9a24fe3.
PR Checklist:
PR
QA
Specifics
primary_scriptdefinition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsetsdefinitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong,chinese-simplified,chinese-traditional,korean,japanese.Release
minisite_urldefinition in the METADATA.pb file for commissioned projectstagsare added for NEW FONTS