Open
Conversation
Collaborator
|
You could just also use cvdalloc and avoid the slowdowns, but I'll take a look. |
3405691582
reviewed
Apr 1, 2026
bridadan
force-pushed
the
optimize_tap_interface_check
branch
3 times, most recently
from
fa24dd4 to
a5f7edf
Compare
3405691582
approved these changes
Apr 1, 2026
jemoreira
approved these changes
Apr 1, 2026
Before this change, the TAP interface check would search through every active process' file descriptors to find which tap interfaces were in use. Instead, now we attempt to open each TAP interface and report any errors. This reduces the runtime of the TAP interface check from about 6 seconds to under 0.1 seconds (when tested on my workstation). Bug: 401259067 Test: check launcher.log for total runtime improvement
bridadan
force-pushed
the
optimize_tap_interface_check
branch
from
a5f7edf to
d3a9240
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, the TAP interface check would search through every active process' file descriptors to find which tap interfaces were in use.
Instead, now we attempt to open each TAP interface and report any errors. This reduces the runtime of the TAP interface check from about 6 seconds to under 0.1 seconds (when tested on my workstation).
Bug: 401259067
Test: check launcher.log for total runtime improvement