feat(session): add DisplayName field to CreateRequest#707
Open
rubda wants to merge 1 commit intogoogle:mainfrom
Open
feat(session): add DisplayName field to CreateRequest#707rubda wants to merge 1 commit intogoogle:mainfrom
rubda wants to merge 1 commit intogoogle:mainfrom
Conversation
The Python ADK supports setting display_name on session creation via **kwargs passthrough, but the Go ADK's CreateRequest struct has no equivalent field. This forces users to work around the limitation by storing names in session state or making separate UpdateSession calls. Add DisplayName to CreateRequest and wire it through to the Vertex AI protobuf Session when creating sessions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Testing Plan
Unit Tests:
Added:
TestCreateSessionProto_DisplayNameinsession/vertexai/vertexai_test.go— verifies DisplayName is mapped to the protobuf Session.Create/with_display_namein the shared service test suite (session/session_test/service_suite.go) — verifies all implementations accept DisplayName without error.Manual End-to-End (E2E) Tests:
The change adds one field to
CreateRequestand passes it through toaiplatformpb.Session.DisplayNamewhen creating Vertex AI sessions. Verified by inspecting the proto construction and running the existing replay-based Vertex AI test suite — all existing tests continue to pass sinceDisplayNamedefaults to the zero value (empty string), which is the previous behavior.Checklist
Additional context
The Python ADK supports this via
**kwargspassthrough inVertexAiSessionService.create_session. The underlying Vertex AI protobufSessionmessage already hasDisplayName— this change simply exposes it through the Go ADK'sCreateRequest.Changes:
session/service.go— AddDisplayName stringtoCreateRequestsession/vertexai/vertexai_client.go— SetDisplayNameon the protobufSessionsession/vertexai/vertexai_test.go— Proto construction testsession/session_test/service_suite.go— Shared suite test