fix: copy ThoughtSignature in generateRequestConfirmationEvent#659
Open
majiayu000 wants to merge 1 commit intogoogle:mainfrom
Open
fix: copy ThoughtSignature in generateRequestConfirmationEvent#659majiayu000 wants to merge 1 commit intogoogle:mainfrom
majiayu000 wants to merge 1 commit intogoogle:mainfrom
Conversation
The function was using utils.FunctionCalls() which extracts only *genai.FunctionCall from parts, discarding the ThoughtSignature field on the parent *genai.Part. Build a map from FunctionCall.ID to ThoughtSignature and set it on the new confirmation Part. Fixes google#656 Signed-off-by: majiayu000 <[email protected]>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This was referenced Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #656
generateRequestConfirmationEventusesutils.FunctionCalls()which extracts only*genai.FunctionCallfrom parts, discarding theThoughtSignaturefield on the parent*genai.Part. When building the newadk_request_confirmationPart,ThoughtSignaturewas never copied.Fix: build an additional map from
FunctionCall.IDtoThoughtSignatureby iterating overfunctionCallEvent.Content.Partsdirectly. When creating the newgenai.Part, look up and set theThoughtSignaturefrom this map.Added test case in
TestGenerateRequestConfirmationEventto verifyThoughtSignatureis preserved.