Merged
Conversation
Signed-off-by: cfc4n <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR targets a build failure on Windows by cleaning up unused imports and consolidating duplicate code.
- Removed the unused "strings" import and duplicate isAllowedCommand function from services/command_exec.go.
- Added the isAllowedCommand implementation to services/command.go for centralized command validation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| services/command_exec.go | Removed duplicate isAllowedCommand function and unnecessary "strings" import. |
| services/command.go | Introduced isAllowedCommand function for command validation. |
Comments suppressed due to low confidence (1)
services/command.go:159
- [nitpick] Consider adding unit tests for isAllowedCommand to cover both simple and piped command scenarios.
+// isAllowedCommand checks if the command is allowed based on the configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.