Skip to content

feat: rename and update references for MoLing to MoLing MineCraft#2

Merged
cfc4n merged 3 commits intomasterfrom
update-mc
Apr 20, 2025
Merged

feat: rename and update references for MoLing to MoLing MineCraft#2
cfc4n merged 3 commits intomasterfrom
update-mc

Conversation

@cfc4n
Copy link
Copy Markdown
Member

@cfc4n cfc4n commented Apr 20, 2025

This pull request introduces a comprehensive renaming and rebranding effort from "MoLing" to "MoLing MineCraft," along with enhancements to the Minecraft server management functionality. The changes span across workflows, documentation, configuration, and code logic, ensuring consistency and improved functionality.

Rebranding and Naming Updates:

  • Renamed workflow names and job titles in .github/workflows/go-test.yml and .github/workflows/release.yml to "MoLing MineCraft" for clarity and alignment with the new branding. [1] [2] [3]
  • Updated references in the Makefile and README files to reflect the new name "MoLing MineCraft" and updated commands, repository URLs, and binary names accordingly. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Codebase Updates:

  • Updated constants and descriptions in cli/cmd/root.go and cli/cmd/client.go to reflect the rebranding, including CLI commands, descriptions, and paths. [1] [2]
  • Adjusted test configurations and paths in services/config_test.go to align with the new naming convention. [1] [2]

Minecraft Server Enhancements:

  • Added new fields (responseChans, pipesClosedMap, and associated mutexes) to MinecraftServer in services/minecraft.go to improve server log handling and manage concurrent command responses. [1] [2]
  • Enhanced the logPipe method to handle stdout-specific outputs and forward responses to waiting channels, improving server interaction capabilities. [1] [2]
  • Improved the server shutdown process by marking pipes as closed in Close to prevent resource leaks.

Dependency Cleanup:

  • Removed unused dependencies in go.mod, streamlining the project and reducing potential maintenance overhead.

These changes ensure a cohesive transition to the new branding while enhancing the functionality and maintainability of the Minecraft server management system.

@cfc4n cfc4n added the enhancement New feature or request label Apr 20, 2025
@cfc4n cfc4n merged commit 232a69e into master Apr 20, 2025
6 checks passed
@cfc4n cfc4n deleted the update-mc branch April 20, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant