docs: fix typos in S3 comments and correct SFTP Getwd logging#3227
Open
Vegapunk-debug wants to merge 1 commit intogofr-dev:developmentfrom
Open
docs: fix typos in S3 comments and correct SFTP Getwd logging#3227Vegapunk-debug wants to merge 1 commit intogofr-dev:developmentfrom
Vegapunk-debug wants to merge 1 commit intogofr-dev:developmentfrom
Conversation
Author
|
@aryanmehrotra, please review my PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Noticed a few stale "FTP" references in the S3 package (likely leftovers from a past copy-paste) and a small logging bug in the SFTP provider.
s3/fs.gocomments and corrected a minor grammar slip in theConnectmethod.Getwdmethod insftp/fs.go, which was incorrectly logging the operation as "STAT" instead of "GETWD".Connectcomments to specify it's an SFTP server.Mention the issue number(s) this PR addresses (if applicable).
N/A
Highlight the motivation behind the changes and the expected benefits.
Bring the documentation in line with the actual implementations and fix a minor observability bug in the SFTP logs developers see the correct operation name.
Additional Information:
Mention any relevant dependencies or external libraries used.
None.
Include screenshots or code snippets (if necessary) to clarify the changes.
These are strictly non-functional comment and string fixes, so they are zero-risk to the core logic.
Checklist:
goimportandgolangci-lint.Thank you!