chore: fix typo in logger comment#3226
Open
singhankit001 wants to merge 2 commits intogofr-dev:developmentfrom
Open
chore: fix typo in logger comment#3226singhankit001 wants to merge 2 commits intogofr-dev:developmentfrom
singhankit001 wants to merge 2 commits intogofr-dev:developmentfrom
Conversation
Umang01-hash
requested changes
Apr 6, 2026
| // and additional health check paths of services. | ||
| func isLogProbeDisabled(probes LogProbes, urlPath string) bool { | ||
| // if probes is not disabled, dont need to check for default probe paths | ||
| // if probes are not disabled, we don't need to check for default probe paths |
Member
There was a problem hiding this comment.
If probes are enabled, we don't need to check the default probe paths. this sounds better i think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed 'dont' to 'don't' and 'probes is' to 'probes are' in logger.go