Handle invalid AudioStream playback positions#119446
Open
Akosmo wants to merge 1 commit into
Open
Conversation
0df199e to
d7ff48b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
Infinite Loop#117856frames_mixedoverflow inAudioStreamPlaybackMP3andAudioStreamPlaybackOggVorbis#96384Additional information
This pull request is an alternative to #119120 , where instead of
seek()andplay()functions allowing invalid playback positions, and just setting them to0, they instead stop playback and return with an error message. This alternative exists after it was discussed in an audio meeting that invalid playback positions should be handled with an error, so the user can handle possible unexpected values.I changed the order of some lines in the
start()function ofAudioStreamWAV, but it seems to function the same. I did this to avoid code repetition.I tested this by using both functions directly in a player. I set the stream to Ogg, MP3, and WAV streams. I tried play with loop disabled and enabled, with loop offset and beat count at different values, and playing from the stream importer window too. Because of the large amount of cases, I could possibly have missed a case, but having dealt with this before on the other PR, I believe everything looks fine.
Read this PR for more info about my original attempt at fixing the issue, and why I'm handling it in the
seek()function