Skip to content

ci: Enable coverage and test results reporting #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buenaflor merged 5 commits into from
Apr 2, 2026
+39 −32
Merged

ci: Enable coverage and test results reporting #3618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
93c6ea5
ci: Enable coverage and test results reporting
buenaflor Apr 1, 2026
caf2eb6
ci(link): Lower min-coverage to 3%
buenaflor Apr 1, 2026
1133405
fix(ci): Use matrix.target for Flutter package workflows
buenaflor Apr 1, 2026
27e756f
Increase minimum coverage threshold to 85%
buenaflor Apr 2, 2026
c590654
Update minimum coverage requirement to 85%
buenaflor Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions .github/workflows/firebase_remote_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ concurrency:

jobs:
build:
name: '${{ matrix.os }} | ${{ matrix.sdk }}'
runs-on: ${{ matrix.os }}-latest
name: '${{ matrix.target }} | ${{ matrix.sdk }}'
runs-on: ${{ matrix.target == 'linux' && 'ubuntu' || matrix.target }}-latest
timeout-minutes: 30
strategy:
fail-fast: false
matrix:
os: [macos, ubuntu, windows]
target: [macos, linux, windows]
sdk: [stable, beta]

steps:
Expand All @@ -38,16 +38,20 @@ jobs:
- uses: ./.github/actions/flutter-test
with:
directory: packages/firebase_remote_config
web: false

# TODO: don't set coverage for now to finish publishing it
# - uses: ./.github/actions/coverage
# if: runner.os == 'Linux' && matrix.sdk == 'stable'
# with:
# token: ${{ secrets.CODECOV_TOKEN }}
# directory: firebase_remote_config
# coverage: sentry_firebase_remote_config
# min-coverage: 55
- uses: ./.github/actions/coverage
if: matrix.target == 'linux' && matrix.sdk == 'stable'
with:
token: ${{ secrets.CODECOV_TOKEN }}
directory: packages/firebase_remote_config
coverage: sentry_firebase_remote_config
min-coverage: 85

- uses: ./.github/actions/test-results
if: ${{ !cancelled() }}
with:
token: ${{ secrets.CODECOV_TOKEN }}
flags: sentry_firebase_remote_config-${{ matrix.target }}-${{ matrix.sdk }}

analyze:
uses: ./.github/workflows/analyze.yml
Expand Down
15 changes: 7 additions & 8 deletions .github/workflows/link.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,13 @@ jobs:
directory: packages/link
web: false

# TODO: don't set coverage for now to finish publishing it
# - uses: ./.github/actions/coverage
# if: runner.os == 'Linux' && matrix.sdk == 'stable'
# with:
# token: ${{ secrets.CODECOV_TOKEN }}
# directory: link
# coverage: sentry_link
# min-coverage: 55
- uses: ./.github/actions/coverage
if: runner.os == 'Linux' && matrix.sdk == 'stable'
with:
token: ${{ secrets.CODECOV_TOKEN }}
directory: packages/link
coverage: sentry_link
min-coverage: 3
Copy link
Copy Markdown
Contributor Author

@buenaflor buenaflor Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the package really has that low coverage

Copy link
Copy Markdown
Contributor Author

@buenaflor buenaflor Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we adopted the package externally but we should in the future add some more coverage

Copy link
Copy Markdown
Collaborator

@denrase denrase Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 ^^


- uses: ./.github/actions/test-results
if: ${{ !cancelled() }}
Expand Down
28 changes: 16 additions & 12 deletions .github/workflows/supabase.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ concurrency:

jobs:
build:
name: '${{ matrix.os }} | ${{ matrix.sdk }}'
runs-on: ${{ matrix.os }}-latest
name: '${{ matrix.target }} | ${{ matrix.sdk }}'
runs-on: ${{ matrix.target == 'linux' && 'ubuntu' || matrix.target }}-latest
timeout-minutes: 30
strategy:
fail-fast: false
matrix:
os: [macos, ubuntu, windows]
target: [macos, linux, windows]
sdk: [stable, beta]

steps:
Expand All @@ -39,16 +39,20 @@ jobs:
- uses: ./.github/actions/flutter-test
with:
directory: packages/supabase
web: false

# TODO: don't set coverage for now to finish publishing it
# - uses: ./.github/actions/coverage
# if: runner.os == 'Linux' && matrix.sdk == 'stable'
# with:
# token: ${{ secrets.CODECOV_TOKEN }}
# directory: packages/supabase
# coverage: sentry_supabase
# min-coverage: 55
- uses: ./.github/actions/coverage
if: matrix.target == 'linux' && matrix.sdk == 'stable'
with:
token: ${{ secrets.CODECOV_TOKEN }}
directory: packages/supabase
coverage: sentry_supabase
min-coverage: 85

- uses: ./.github/actions/test-results
if: ${{ !cancelled() }}
with:
token: ${{ secrets.CODECOV_TOKEN }}
flags: sentry_supabase-${{ matrix.target }}-${{ matrix.sdk }}

analyze:
uses: ./.github/workflows/analyze.yml
Expand Down
Loading