fix: Prevent stale page writes from recreating moved page directories#8057
Open
afbora wants to merge 1 commit intodevelop-patchfrom
Open
fix: Prevent stale page writes from recreating moved page directories#8057afbora wants to merge 1 commit intodevelop-patchfrom
afbora wants to merge 1 commit intodevelop-patchfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a race condition where a stale page instance could still write to an old page path after the page had been moved during reordering.
When that happened, the write path could recreate the missing directory and produce ghost or duplicate page folders.
The fix adds a guard before writing page content. If the original root no longer exists, Kirby resolves the page again from the current app state. If the page was moved in the meantime, the write now fails instead of recreating the old path.
I've implemented the suggestion in my previous comment. I hope you like it:
#7964 (comment)
Changelog
✨ Enhancements
Docs
For review team