fix: Move picker search props into shared models dialog mixin

[afbora]

Description

This fixes search: false for picker fields like files, pages, and users.

The problem was that the search prop got lost in the wrapper dialogs before it reached the shared models dialog. I fixed it by moving the Search mixin into the shared props export in ModelsDialog.vue, so the wrapper dialogs receive it as well.

Changelog

🐛 Bug fixes

• Fixed picker dialogs so the search: false option now works as expected Fieldtype files: setting search to false does not hide search #8053

Docs

For review team

• Add lab and/or sandbox examples (wherever helpful)
• Add changes & docs to release notes draft in Notion

[distantnative]

@afbora lookjbg at your changes it looks to me like we could add it centrally to ModelDialogProps instead three times individually?

[afbora]

import { props as ModelsDialogProps } from "./ModelsDialog.vue";

kirby/panel/src/components/Dialogs/ModelsDialog.vue

Lines 45 to 74 in e3721bb

	import Dialog from "@/mixins/dialog.js";
	import Search from "@/mixins/search.js";
	export const props = {
	props: {
	endpoint: String,
	empty: Object,
	fetchParams: Object,
	item: {
	type: Function,
	default: (item) => item
	},
	max: Number,
	multiple: {
	type: Boolean,
	default: true
	},
	size: {
	type: String,
	default: "medium"
	},
	value: {
	type: Array,
	default: () => []
	}
	}
	};
	export default {
	mixins: [Dialog, Search, props],

@distantnative ModelsDialogProps is imported from ModelsDialog.vue, but it only includes the exported props object, not the component’s full mixin chain. So even though ModelsDialog itself uses the Search mixin, those props are not available on the wrapper dialogs through ModelsDialogProps.

That’s why I added the definitions in the three wrapper dialogs for now. The cleaner alternative would be to move the relevant search props directly into the shared props export in ModelsDialog.vue, so they are handled centrally there.

What do you think?

[distantnative]

@afbora you should be able to add the search mixin to const props in ModelsDialog.

[afbora]

@distantnative Oh, that’s interesting. I assumed that since search mixin was already included in the default export, adding it again to the shared props constant wouldn’t make a difference. Should search mixin stay in the default export as well, or is adding it only to that shared props constant enough?

[afbora]

Now I've implemented @distantnative suggestion. Now ready to review @getkirby/frontend

[distantnative]

@afbora Could you please add a test case for files, pages and users field in the sandbox blueprints?

[afbora]

@distantnative Done via getkirby/sandbox#28

[distantnative]

Thank you, works for me