[fix] Multisite issue when using find function#3553
Open
hdwebpros wants to merge 1 commit intogetgrav:developfrom
Open
[fix] Multisite issue when using find function#3553hdwebpros wants to merge 1 commit intogetgrav:developfrom
find function#3553hdwebpros wants to merge 1 commit intogetgrav:developfrom
Conversation
When running multisite with subfolder, the route includes the subfolder. The `find` function returns `null` since it only needs the page route, without the subfolder. This commit removes that subfolder as `$this->base`, which fixes the route on multisite with subfolder. This has been tested on multisite with Grav v1.7.30 and Flex Objects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running multisite with subfolder, the route includes the subfolder. The
findfunction returnsnullsince it only needs the page route, without the subfolder.This commit removes that subfolder as
$this->base, which fixes the route on multisite with subfolder.This has been tested on multisite with Grav v1.7.30 and Flex Objects