fix(comments): raise edit limit to 4000 to match create (#1535)#1544
Merged
Conversation
EditComment.Validate rejected content over 2000 chars while AddNewComment allowed up to 4000, so users could post a comment but not edit it. Aligns the edit cap and the matching frontend save-button gating in ShowComment to 4000, and adds a boundary test mirroring TestAddNewComment_AtMaxLength. Co-Authored-By: Claude Opus 4.7 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EditComment.Validaterejected content over 2000 chars whileAddNewComment.Validateallowed up to 4000, so a user could post a comment but be blocked from editing their own. Aligns the edit cap to 4000.ShowComment(newContent.length > 4000) —maxLength={4000}was already correct.TestEditComment_AtMaxLengthso the boundary is covered the same wayTestAddNewComment_AtMaxLengthcovers create.Followup to #1535 (initial 4000-char create cap landed in 8295d10).
Test plan
make lintcleangodotenv -f .test.env go test ./app/actions -run 'TestAddNewComment|TestEditComment' -v— all 4 tests passmake watch: edit an existing comment, paste in 4001 chars → counter goes red, Save button disables🤖 Generated with Claude Code