Abstract inlined code in fullchem_mod.F90 to separate subroutines in order to reduce clutter and duplciation#3235
Draft
Abstract inlined code in fullchem_mod.F90 to separate subroutines in order to reduce clutter and duplciation#3235
Conversation
yantosca
added
category: Feature Request
GeosCore/fullchem_mod.F90 - Abstracted inlined code into the following subroutines: - Zeroing of dummy species --> Zero_Dummy_Species - ConcAfterChem diagnostic --> ArchiveConcAfterChem - Photolysis rates /diags --> Get_Photolysis_Rates - CESM unphysical fix --> CESM_Photolyze_Soluble_Aerosols CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
GeosCore/fullchem_mod.F90 - Moved the IF statements that zero diagnostic arrays at the start of DO_FULLCHEM to routine Zero_Diagnostics_at_Start_of_Fullchem - Moved the archival of the RxnRates, RxnConst, and SatDiagnRxnRates collections to routine Archive_RxnRates_Diags Signed-off-by: Bob Yantosca <[email protected]>
yantosca
force-pushed
the
feature/abstract-code-in-fullchem-mod
branch
from
e8c9c2d to
056dcb6
Compare
Contributor
Author
|
I have rebased this PR atop GEOS-Chem 14.7.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Describe the update
In this PR we seek to abstract long inlined code blocks in
GeosCore/fullchem_mod.F90(e.g. where diagnostics are archived, etc). into separate subroutines. This will reduce clutter and avoid duplication.DO_FULLCHEMZero_Diagnostics_at_Start_of_FullchemZero_Dummy_SpeciesArchive_ConcBeforeChemGet_Photolysis_RatesCESM_Photolyze_Soluble_AerosolsArchive_RxnRate_DiagsExpected changes
This will be a no-diff-to-benchmark update.
Related Github Issue
Tagging @lizziel @msulprizio