Skip to content

Allow deletion of remaining date fields (follow-up to PR #263) #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mholthausen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow deletion of remaining date fields (follow-up to PR #263) #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/lib/components/Form/Field/09_CreatedField.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,7 @@

const { getValue } = getFormContext();
const valueFromData = $derived(getValue<string>(KEY));
let value = $state('');
$effect(() => {
if (valueFromData && !value) {
value = new Date(valueFromData).toISOString().split('T')[0];
}
});
let value = $derived(valueFromData ? new Date(valueFromData).toISOString().split('T')[0] : '');

let showCheckmark = $state(false);
const fieldConfig = MetadataService.getFieldConfig<string>(9);
Expand Down
12 changes: 1 addition & 11 deletions src/lib/components/Form/Field/10_PublishedField.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,7 @@

const { getValue } = getFormContext();
const valueFromData = $derived(getValue<string>(KEY));
let value = $state('');
let initialized = false;

// TODO: this should be replaced by deriving "value". This
// should be possible after svelte is updated to the latest version
// https://github.com/gdi-be/mde-client/pull/261
$effect(() => {
if (valueFromData && !initialized) {
value = new Date(valueFromData).toISOString().split('T')[0];
}
});
let value = $derived(valueFromData ? new Date(valueFromData).toISOString().split('T')[0] : '');

let showCheckmark = $state(false);
const fieldConfig = MetadataService.getFieldConfig<string>(10);
Expand Down
13 changes: 5 additions & 8 deletions src/lib/components/Form/Field/11_LastUpdatedField.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,17 @@

const { getValue } = getFormContext();
const valueFromData = $derived(getValue<string>(KEY, metadata));
let value = $state('');

$effect(() => {
if (valueFromData && !value) {
value = new Date(valueFromData).toISOString().split('T')[0];
}
});
let value = $derived(valueFromData ? new Date(valueFromData).toISOString().split('T')[0] : '');
const fieldConfig = MetadataService.getFieldConfig<string>(11);
let validationResult = $derived(fieldConfig?.validator(value)) as ValidationResult;

let showCheckmark = $state(false);

const onBlur = async () => {
const response = await MetadataService.persistValue(KEY, new Date(value!).toISOString());
const response = await MetadataService.persistValue(
KEY,
value ? new Date(value!).toISOString() : ''
);
if (response.ok) {
showCheckmark = true;
}
Expand Down
18 changes: 6 additions & 12 deletions src/lib/components/Form/Field/12_ValidityRangeField.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,14 @@

const { getValue } = getFormContext();
const startValueFromData = $derived(getValue<string>(FROM_KEY));
let startValue = $state('');
$effect(() => {
if (startValueFromData && !startValue) {
startValue = new Date(startValueFromData).toISOString().split('T')[0];
}
});
let startValue = $derived(
startValueFromData ? new Date(startValueFromData).toISOString().split('T')[0] : ''
);

const endValueFromData = $derived(getValue<string>(TO_KEY));
let endValue = $state('');
$effect(() => {
if (endValueFromData && !endValue) {
endValue = new Date(endValueFromData).toISOString().split('T')[0];
}
});
let endValue = $derived(
endValueFromData ? new Date(endValueFromData).toISOString().split('T')[0] : ''
);

let showCheckmark = $state(false);
const fromFieldConfig = MetadataService.getFieldConfig<string>(12);
Expand Down
Loading