Skip to content

Fix unused result warnings (backport #493) (backport #496)#497

Merged
scpeters merged 1 commit intoign-fuel-tools7from
mergify/bp/ign-fuel-tools7/pr-496
Mar 12, 2026
Merged

Fix unused result warnings (backport #493) (backport #496)#497
scpeters merged 1 commit intoign-fuel-tools7from
mergify/bp/ign-fuel-tools7/pr-496

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Mar 11, 2026

🦟 Bug fix

Fixes compiler warnings, related to gazebosim/gz-transport#810

Summary

As noted in the protobuf 34.0 release notes [[nodiscard]] has been added to many APIs, which is causing several unused-result compiler warnings in this package:

This checks the result of each affected API to fix the compiler warnings, matching the error response strategy used in nearby code for each instance.

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the fix (as needed)
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Backports: If this is a backport, please use Rebase and Merge instead.


This is an automatic backport of pull request #493 done by [Mergify](https://mergify.com).
This is an automatic backport of pull request #496 done by [Mergify](https://mergify.com).

@mergify mergify Bot requested a review from nkoenig as a code owner March 11, 2026 20:11
@mergify mergify Bot added the conflicts label Mar 11, 2026
@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented Mar 11, 2026

Cherry-pick of c381002 has failed:

On branch mergify/bp/ign-fuel-tools7/pr-496
Your branch is up to date with 'origin/ign-fuel-tools7'.

You are currently cherry-picking commit c381002.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/FuelClient.cc
	modified:   src/gz.cc

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/Interface.cc

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions Bot added the 🏯 fortress Ignition Fortress label Mar 11, 2026
@mergify mergify Bot mentioned this pull request Mar 11, 2026
11 tasks
@scpeters
Copy link
Copy Markdown
Member

I'll try again

@scpeters scpeters closed this Mar 11, 2026
@github-project-automation github-project-automation Bot moved this from Inbox to Done in Core development Mar 11, 2026
@scpeters scpeters reopened this Mar 11, 2026
@github-project-automation github-project-automation Bot moved this from Done to Inbox in Core development Mar 11, 2026
@scpeters scpeters force-pushed the mergify/bp/ign-fuel-tools7/pr-496 branch from 6de9cb4 to c2b7d2f Compare March 11, 2026 22:05
Signed-off-by: Steve Peters <[email protected]>
(cherry picked from commit d0382af)
(cherry picked from commit c381002)
@scpeters scpeters force-pushed the mergify/bp/ign-fuel-tools7/pr-496 branch from c2b7d2f to 259fa52 Compare March 11, 2026 23:15
@github-project-automation github-project-automation Bot moved this from Inbox to In review in Core development Mar 12, 2026
@scpeters scpeters merged commit cca4ff2 into ign-fuel-tools7 Mar 12, 2026
8 checks passed
@scpeters scpeters deleted the mergify/bp/ign-fuel-tools7/pr-496 branch March 12, 2026 04:31
@github-project-automation github-project-automation Bot moved this from In review to Done in Core development Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏯 fortress Ignition Fortress

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants