Skip to content

Datatables#10

Open
NightZpy wants to merge 2 commits intogarygreen:masterfrom
NightZpy:master
Open

Datatables#10
NightZpy wants to merge 2 commits intogarygreen:masterfrom
NightZpy:master

Conversation

@NightZpy
Copy link
Copy Markdown

  • Fixed header.
  • Reorder columns.

@Braunson Braunson mentioned this pull request Nov 8, 2017
@Braunson
Copy link
Copy Markdown

Braunson commented Nov 8, 2017

@NightZpy Can you fix the conflicts. @garygreen once that's done can you merge this?

@garygreen
Copy link
Copy Markdown
Owner

I was originally not much of a fan of this idea because I think paginating a list of routes is incredibly annoying - flicking through 40 different pages to find the route you want isn't a friendly experience.

Sorting columns could be useful, however I feel that the display order of the routes is extremely important, as routes are matched in order of priority - if we did allow for sorting of columns we should add a "Number" column of some kind, so you can reset the routes back to the order they will actually be matched in.

Finding routes / grepping can easily be done by just CTRL + F in the browser, it's pretty simple already, no?

Overall, I'm not sure adding data tables will add a huge amount of value except increase the complexity of an already simple package. But I'm not adverse to changing my way of thinking on it 😄

@andrey-helldar
Copy link
Copy Markdown

I understand that the question in this thread is very old and, apparently, @garygreen is busy with the main work, so I released my version from the fork as self-contained package.
It's easier to look at a package than to talk about its changes: https://github.com/andrey-helldar/pretty-routes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants