Skip to content

SNDH files with optimized string-arrays needs special attention.#63

Closed
mywave82 wants to merge 1 commit intofrno7:mainfrom
mywave82:sndh-substrings
Closed

SNDH files with optimized string-arrays needs special attention.#63
mywave82 wants to merge 1 commit intofrno7:mainfrom
mywave82:sndh-substrings

Conversation

@mywave82
Copy link
Copy Markdown
Contributor

Without this, if fails to parse tags beyond the "FLAG" tag, since the last string given by the index, is not the last string in the tag (optimization).

https://sndh.atari.org/files/sndh2026_lf.zip sndh_lf/AD/DMA/ADN_Quiz.sndh

@mywave82
Copy link
Copy Markdown
Contributor Author

Might fix #59

@frno7
Copy link
Copy Markdown
Owner

frno7 commented Mar 12, 2026

Many thanks, @mywave82! Excellent finding and fix. Merged in commit f90c7ca.

Incidentally, I saw your commit a0ac845 during fetching. That looks fairly impressive, and I would very much like to support your refactoring effort! Since this isn’t on topic for the present issue, would you like to open a discussion about it?

@mywave82
Copy link
Copy Markdown
Contributor Author

Sure, I created a discussion #66

You can close this PR probably.

The original problem triggering the creation of #59 seems to originate in this, but discussion perhaps wondered away slightly.

@frno7 frno7 closed this Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants