SNDH files with optimized string-arrays needs special attention.#63
Closed
mywave82 wants to merge 1 commit intofrno7:mainfrom
Closed
SNDH files with optimized string-arrays needs special attention.#63mywave82 wants to merge 1 commit intofrno7:mainfrom
mywave82 wants to merge 1 commit intofrno7:mainfrom
Conversation
Contributor
Author
|
Might fix #59 |
Owner
|
Many thanks, @mywave82! Excellent finding and fix. Merged in commit f90c7ca. Incidentally, I saw your commit a0ac845 during fetching. That looks fairly impressive, and I would very much like to support your refactoring effort! Since this isn’t on topic for the present issue, would you like to open a discussion about it? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, if fails to parse tags beyond the "FLAG" tag, since the last string given by the index, is not the last string in the tag (optimization).
https://sndh.atari.org/files/sndh2026_lf.zip sndh_lf/AD/DMA/ADN_Quiz.sndh