feat: allow passing async ability function in channel options#61
Open
lukashass wants to merge 2 commits intofratzinger:mainfrom
Open
feat: allow passing async ability function in channel options#61lukashass wants to merge 2 commits intofratzinger:mainfrom
lukashass wants to merge 2 commits intofratzinger:mainfrom
Conversation
Contributor
Author
|
@fratzinger Have you seen this? 😉 |
Owner
|
Thanks for the nudge and sorry for the delay! If I get it right, making You can override For example, I do this: app.on("logout", (payload: any, { connection }) => {
if (connection) {
delete connection.ability;
// you can also do something like:
// connection.ability = await defineAbility(...);
app.channel("anonymous").join(connection);
}
});Does that help in any way? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to update the ability for channels by passing a function to
channels.makeOptions:Since
defineAbilitiesForisasync(for querying data needed to create the ability, similar to #31), I added:awaitbefore callingoptions.abilitygetAbilitywhenoptions.restrictFields === trueIf there is a better way to update stale abilities for channels, any pointers in the right direction would be much appreciated.