Improve pt-BR coverage and localize hardcoded onboarding UI#1856
Open
idlukakas wants to merge 4 commits intofrappe:developfrom
Open
Improve pt-BR coverage and localize hardcoded onboarding UI#1856idlukakas wants to merge 4 commits intofrappe:developfrom
idlukakas wants to merge 4 commits intofrappe:developfrom
Conversation
idlukakas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves Brazilian Portuguese coverage in Frappe CRM and removes a remaining class of English-only UI strings that could not be translated through
crm/locale/pt_BR.poalone.The visible problem for pt-BR users was that the main CRM views were partially translated, but onboarding/help/sidebar surfaces still rendered English strings such as
Getting started,Welcome to Frappe CRM,Skip all,Start now,Help centre,Loved the demo?, and trial-banner copy. From the user perspective, that made the product feel only partially localized even when the site and user language were set topt-BR.The underlying cause was split in two parts. First, the
pt_BR.pocatalog still had missing or inaccurate Brazilian Portuguese entries for some CRM route labels and onboarding-related strings. Second, some of the remaining English strings were not coming from CRM-local templates that already pass through the app's gettext catalog. They were rendered byfrappe-uionboarding/help/banner components with hardcoded English copy, so updating the locale file alone was not enough to localize those surfaces.This change addresses both layers. It expands and normalizes the Brazilian Portuguese catalog in
crm/locale/pt_BR.po, including route labels and onboarding/help text, and it adds local Vue wrappers for the onboarding, help-center, and billing banner components so their labels now call__()and can be translated by CRM.AppSidebar.vueis then updated to import these local wrappers instead of the English-only variants.The result is that the existing CRM localization flow can now cover these UI areas consistently, which should make future pt-BR usage much less fragmented and reduce the need for downstream patching in forks.
Validation used for this patch:
msgfmt -c -o /tmp/pt_BR-pr.mo crm/locale/pt_BR.ponpx eslint src/components/Layouts/AppSidebar.vue src/components/Billing/SignupBanner.vue src/components/Billing/TrialBanner.vue src/components/Help/HelpCenter.vue src/components/Help/HelpModal.vue src/components/Onboarding/GettingStartedBanner.vue src/components/Onboarding/IntermediateStepModal.vue src/components/Onboarding/OnboardingSteps.vueNotes:
crm/locale/main.potin this PR because the extraction toolchain available in this environment produced a noisy, non-minimal POT diff againstdevelop. The runtime-facing localization changes here are isolated and reviewable on their own.